[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3 2/2] spec: don't use chkconfig --list



On 12/07/2011 05:50 PM, Laine Stump wrote:
> On 12/06/2011 06:47 PM, Eric Blake wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=694403 reports that
>> the specfile is incorrectly checking for a running libvirt-guests
>> service.  For example,
>>
>> $ LC_ALL=es_ES chkconfig --list libvirt-guests
>> libvirt-guests       0:desactivado         1:desactivado      
>> 2:desactivado     3:activo     4:activo  5:activo        6:desactivado
>>
>> will fail to find 5:on, even though it is active.  But chkconfig
>> already has a mode where you can silently use the exit status to
>> check for an active service.
>>
>>   # We check this by looking to see if the daemon is already installed
>> -/sbin/chkconfig --list libvirtd 1>/dev/null 2>&1
>> -if test $? != 0&&  test ! -f
>> %{_sysconfdir}/libvirt/qemu/networks/default.xml
>> +if ! /sbin/chkconfig&&  test ! -f

Actually, in my testing, I realized this has to be '/bin/chkconfig
libvirtd', not '/sbin/chkconfig'.

> 
> ACK.

I'll push the corrected version.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]