[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] storage: Activate/deactivate logical volumes only on local node



On 12.12.2011 08:40, Osier Yang wrote:
> From: Rommer <rommer active by>
> 
> Current "-ay | -an" has problems on pool starting/refreshing if
> the volumes are clustered. Rommer has posted a patch to list 2
> months ago.
> 
> https://www.redhat.com/archives/libvir-list/2011-October/msg01116.html
> 
> But IMO we shouldn't skip the inactived vols. So this is a squashed
> patch by Rommer.
> 
> Signed-off-by: Rommer <rommer active by>
> ---
>  src/storage/storage_backend_logical.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c
> index 1420ede..6a235f6 100644
> --- a/src/storage/storage_backend_logical.c
> +++ b/src/storage/storage_backend_logical.c
> @@ -51,7 +51,7 @@ virStorageBackendLogicalSetActive(virStoragePoolObjPtr pool,
>      const char *cmdargv[4];
>  
>      cmdargv[0] = VGCHANGE;
> -    cmdargv[1] = on ? "-ay" : "-an";
> +    cmdargv[1] = on ? "-aly" : "-aln";
>      cmdargv[2] = pool->def->source.name;
>      cmdargv[3] = NULL;
>  

Is it just me or vgchange has strange arguments parsing logic?
I'd expect -aly to be the same as -a -l -y as in all other utilities
within unix world. Anyway, that's not show stopper.

ACK

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]