[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: follow directory install conventions



On 09.12.2011 19:08, Eric Blake wrote:
> make uninstall failed:
> 
> rmdir: failed to remove `/etc/sasl2/': Directory not empty
> 
> Fix this by following the conventions already present in
> src/Makefile.am of installing with MKDIR_P, and cleaning up
> any directory in a builtroot while allowing the directory to
> still exist if non-empty in an installed system.
> 
> Reported by Dave Allan.
> 
> * tools/Makefile.am (install-sysconfig, install-initscript)
> (install-systemd): Use MKDIR_P.
> (uninstall-sysconfig, uninstall-initscript, uninstall-systemd):
> Also remove directories.
> * daemon/Makefile.am (install-data-local, install-data-polkit)
> (install-logrotate, install-sysconfig, install-sysctl)
> (install-init-redhat, install-init-upstart, install-init-systemd)
> (install-data-sasl): Use MKDIR_P.
> (uninstall-data-polkit, uninstall-sysconfig, uninstall-sysctl)
> (uninstall-init-redhat, uninstall-init-upstart)
> (uninstall-init-systemd): Also remove directory.
> (uninstall-logrotate): New rule.
> (uninstall-local): Add uninstall-logrotate.
> (uninstall-data-sasl): Allow for non-empty directory.
> ---
> 

ACK, and sorry for not noticing Dave's self-NACK as my e-mail filters
put his e-mail into a different folder.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]