[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] docs: document <address> elements in one place



On Mon, 2011-12-12 at 12:04 -0700, Eric Blake wrote:
> On 12/09/2011 11:58 PM, Laine Stump wrote:
> > On 12/09/2011 06:35 PM, Eric Blake wrote:
> > 
> > I would say something like:
> > 
> > On PowerPC pseries guests, devices can be assigned to the SPAPR VIO bus.
> > It has a flat 64-bit address space, by convention devices are generally
> > located at a multiple of 0x1000, but other addresses are legal and
> > accepted by libvirt. A device can be given an address by specifying the
> > <code>reg</code> attribute, this gives the 64-bit address of the device.
> > If no <code>reg</code> value is specified libvirt will attempt to assign
> > a value for you.
> 
> I think it's a bit redundant to mention that libvirt will assign values
> for you, since I already mentioned that prior to the <dl> list:

Yeah agreed, I missed that bit.

> Given your two reviews, here's what I squashed before pushing.

Looks good to me.

cheers


Attachment: signature.asc
Description: This is a digitally signed message part


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]