[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] tests: plug memory leak on linuxTestNodeInfo



On 13.12.2011 07:45, ajia redhat com wrote:
> From: Alex Jia <ajia redhat com>
> 
> Detected by valgrind. Leak introduced in commit 82ff25e.
> 
> * tests/nodeinfotest.c: avoid memory leak on nodeinfo test case.
> 
> * how to reproduce?
>   % cd tests && valgrind -v --leak-check=full ./nodeinfotest
> 
> * actual valgrind result:
> 
> ==22147== 65 bytes in 1 blocks are definitely lost in loss record 14 of 29
> ==22147==    at 0x4A0610F: realloc (vg_replace_malloc.c:525)
> ==22147==    by 0x330D6FED94: __vasprintf_chk (in /lib64/libc-2.12.so)
> ==22147==    by 0x426697: virVasprintf (stdio2.h:199)
> ==22147==    by 0x426757: virAsprintf (util.c:1695)
> ==22147==    by 0x41585F: linuxTestNodeInfo (nodeinfotest.c:108)
> ==22147==    by 0x416B21: virtTestRun (testutils.c:141)
> ==22147==    by 0x4157EA: mymain (nodeinfotest.c:140)
> ==22147==    by 0x416217: virtTestMain (testutils.c:696)
> ==22147==    by 0x330D61ECDC: (below main) (in /lib64/libc-2.12.so)
> ==22147== 
> ==22147== LEAK SUMMARY:
> ==22147==    definitely lost: 65 bytes in 1 blocks
> ==22147==    indirectly lost: 0 bytes in 0 blocks
> ==22147==      possibly lost: 0 bytes in 0 blocks
> ==22147==    still reachable: 126,126 bytes in 1,341 blocks
> 
> 
> Signed-off-by: Alex Jia <ajia redhat com>
> ---
>  tests/nodeinfotest.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 

Although this is not a dramatic leak, for completeness sake:
ACK & pushed

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]