[libvirt] [PATCH] virsh: support multifunction in attach-disk

[Eric Blake]

On 12/13/2011 12:14 AM, KAMEZAWA Hiroyuki wrote:
> On Tue, 13 Dec 2011 14:51:58 +0800
> Wen Congyang <wency at cn.fujitsu.com> wrote:
> 
>> At 12/13/2011 02:12 PM, KAMEZAWA Hiroyuki Write:
>>> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu at jp.fujitsu.com>
>>>
>>> PCI <address...> can be specified by attach-disk but multifunction cannot
>>> be specified. add --multifunction support.
>>
>> IIRC, libvirt does not support hot plugging multifunction PCI device. Why
>> do you need this feature?

Libvirt might not support it now, but there's no reason we can't add
that support in the future if qemu is taught to be smart enough to
handle it properly.

>>
> 
> live-update is unnecessary. For updating _stopped_ domain's definition with
> virsh script.

Yep, a convincing enough reason to implement this virsh hook now.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20111213/ab11ad7b/attachment-0001.sig>