[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] spec: fix sanlock dependency



At 12/06/2011 01:38 AM, Eric Blake Write:
> * libvirt.spec.in (with_sanlock): On RHEL, don't force sanlock
> on architectures where it isn't available.
> ---
>  libvirt.spec.in |   10 ++++++++--
>  1 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 35762a5..39c814a 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -174,8 +174,14 @@
>  %endif
> 
>  # Enable sanlock library for lock management with QEMU
> -%if 0%{?fedora} >= 16 || 0%{?rhel} >= 6
> -%define with_sanlock  0%{!?_without_sanlock:%{server_drivers}}
> ++# Sanlock is available only on i686 x86_64 for RHEL

According this comment, force sanlock  only on i686 x86_64 for RHEL

> +%if 0%{?fedora} >= 16
> +%define with_sanlock 0%{!?_without_sanlock:%{server_drivers}}
> +%endif
> +%if 0%{?rhel} >= 6
> +%ifnarch i386 i586 i686 x86_64

But here you force it only not on i686 x86_64 for RHEL.

s/ifnarch/ifarch/ ?

Thanks
Wen Congyang

> +%define with_sanlock 0%{!?_without_sanlock:%{server_drivers}}
> +%endif
>  %endif
> 
>  # Disable some drivers when building without libvirt daemon.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]