[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] rpc: retry to call dup() if fcntl with CLOEXEC fails



On 12/14/2011 04:19 AM, dongsu park profitbricks com wrote:
> From: Dongsu Park <dongsu park profitbricks com>
> 
> If fcntl with F_DUPFD_CLOEXEC fails, we need to try again to use dup()
> to get the fd, instead of giving up right away.

NACK.  gnulib guarantees that F_DUPFD_CLOEXEC works (albeit not
atomically), even on systems where it is not implemented natively.
Falling back to dup() is worthless, since gnulib already provided the
necessary fallbacks as part of its rpl_fcntl.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]