[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 5/6] util: Add helpers for safe domain console operations



On 12/13/2011 05:31 PM, Eric Blake wrote:
> On 12/07/2011 11:08 AM, Peter Krempa wrote:
>> This patch adds a set of functions used in creating console streams for
>> domains using PTYs and ensures mutualy exculsive access to the PTYs.
> 
> s/mutualy exculsive/mutually exclusive/
> 

>> ---
>>  configure.ac                   |   37 +++-
>>  src/Makefile.am                |    5 +-
>>  src/libvirt_private.syms       |    6 +
>>  src/util/domain_safe_console.c |  399 ++++++++++++++++++++++++++++++++++++++++
>>  src/util/domain_safe_console.h |   28 +++
>>  5 files changed, 466 insertions(+), 9 deletions(-)
>>  create mode 100644 src/util/domain_safe_console.c
>>  create mode 100644 src/util/domain_safe_console.h
> 
> I've run out of time to finish my review of this today, but the idea
> seems interesting.

Still haven't finished this review, but it fails 'make syntax-check':

po_check
--- ./po/POTFILES.in
+++ ./po/POTFILES.in
@@ -108,6 +108,7 @@
 src/util/command.c
 src/util/conf.c
 src/util/dnsmasq.c
+src/util/domain_safe_console.c
 src/util/event_poll.c
 src/util/hash.c
 src/util/hooks.c
maint.mk: you have changed the set of files with translatable diagnostics;
 apply the above patch

preprocessor_indentation
cppi: src/util/domain_safe_console.c: line 30: not properly indented
maint.mk: incorrect preprocessor indentation

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]