[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 6/8] Remove decl of all APIs related to domain event callbacks & queues



On 12/13/2011 05:38 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The virDomainEventCallbackList and virDomainEventQueue APIs are
> now solely helpers used internally by virDomainEventState APIs.
> Remove their decls from domain_event.h since no driver code should
> need to use them any more.
> 
> * src/conf/domain_event.c: Make virDomainEventCallbackList and
>   virDomainEventQueue APIs static & remove some unused APIs
> * src/conf/domain_event.h, src/libvirt_private.syms: Remove
>   virDomainEventCallbackList and virDomainEventQueue APIs
> ---
>  src/conf/domain_event.c  |  151 +++++++++++++---------------------------------
>  src/conf/domain_event.h  |   64 +-------------------
>  src/libvirt_private.syms |   17 -----
>  3 files changed, 44 insertions(+), 188 deletions(-)

Fun amounts of deletion :)

> +++ b/src/libvirt_private.syms
> @@ -470,18 +470,6 @@ virDomainWatchdogModelTypeToString;
>  # domain_event.h
>  virDomainEventBlockJobNewFromObj;
>  virDomainEventBlockJobNewFromDom;

Huh, these lines weren't sorted (pre-existing).

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]