[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH libvirt-glib 2/2] Add binding for virDomainOpenGraphics



On Thu, Dec 15, 2011 at 05:59:31PM +0100, Christophe Fergeau wrote:
> On Mon, Dec 12, 2011 at 04:04:45PM +0000, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange redhat com>
> > 
> > ---
> >  libvirt-gobject/libvirt-gobject-domain.c |   41 ++++++++++++++++++++++++++++++
> >  libvirt-gobject/libvirt-gobject-domain.h |    6 ++++
> 
> No addition to the .sym file?

Opps, yeah, need that.

> >  2 files changed, 47 insertions(+), 0 deletions(-)
> > 
> > diff --git a/libvirt-gobject/libvirt-gobject-domain.c b/libvirt-gobject/libvirt-gobject-domain.c
> > index 331a533..677d64b 100644
> > --- a/libvirt-gobject/libvirt-gobject-domain.c
> > +++ b/libvirt-gobject/libvirt-gobject-domain.c
> > @@ -637,3 +637,44 @@ cleanup:
> >          virStreamFree(st);
> >      return ret;
> >  }
> > +
> > +
> > +/**
> > + * gvir_domain_open_graphics:
> > + * @dom: the domain
> > + * @idx: the graphics index
> 
> idx refers to the index of the <graphics> device node we are interested in
> in the domain config? The API looks a bit complicated to me, but I'm not
> sure it's easy to come up with something nicer :-/

Yeah, there's not really much of an alternative

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]