[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] build: let autobuild check more code



On 12/15/2011 01:49 AM, Daniel P. Berrange wrote:
> On Wed, Dec 14, 2011 at 11:02:23AM -0700, Eric Blake wrote:
>> Many times, we don't notice a bug in src/libvirt_private.syms
>> until someone attempts a build with modules enabled.  Likewise,
>> some gcc warnings about no % in a printf format string only
>> appear under --disable-nls.  And configure.ac should automatically
>> be excluding modules on mingw without us having to be explicit.
>> Improving autobuild.sh to stress more combinations can only help.
>>
>> * autobuild.sh: Add --with-driver-modules and --disable-nls.  Update
>> mingw build to rely more on configure.ac detection.
>> ---
>>
>> Wow, I've been sitting on this one for a while, and dusted it off
>> from one of my side branches.  This might not address all of Daniel's
>> comments on v1, but it is better than nothing.
>> v1: https://www.redhat.com/archives/libvir-list/2011-March/msg01072.html
>> v2: in response to: https://www.redhat.com/archives/libvir-list/2011-December/msg00620.html
>>
>>  autobuild.sh |   23 ++++++-----------------
>>  1 files changed, 6 insertions(+), 17 deletions(-)
> 
> ACK

Thanks for the review; however, I will defer pushing this patch until I
also have time to fix a couple of fallout problems (my goal is to get
this all squared away before 0.9.9).  In particular, ./autobuild.sh now
fails with:

  CCLD   libvirt_driver_nwfilter.la
../gnulib/lib/.libs/libgnu.a(allocator.o):(.data.rel.ro+0x0): multiple
definition of `stdlib_allocator'
../gnulib/lib/.libs/libgnu.a(allocator.o):(.data.rel.ro+0x0): first
defined here

that is, I think we're incorrectly linking gnulib in from multiple
helper libraries somewhere along the way.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]