[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] migration: Add more specific error code/message on migration abort



On 12/16/2011 04:19 PM, Eric Blake wrote:
On 12/16/2011 07:14 AM, Peter Krempa wrote:
A generic error code was returned, if the user aborted a migration job.
This made it hard to distinguish between a user requested abort and an
error that might have occured. This patch introduces a new error code,

s/occured/occurred/

which is returned if a migration API call fails. This makes it easier to

That wording didn't quite make sense to me - you made it sound like
arbitrary failure gets the new error value.  Maybe a better wording
would be:

This patch introduces a new error code, which is returned in the
specific case of a user abort, while leaving all other failures with
their existing code.

distinguish between failure while mirgrating and an user requested
abort.

  * include/libvirt/virterror.h: - add new error code
  * src/util/virterror.c: - add message for the new error code
  * src/qemu/qemu_migration.h: - Emit operation aborted error instead of
                                 operation failed, on migration abort
---
  include/libvirt/virterror.h |    2 ++
  src/qemu/qemu_migration.c   |    2 +-
  src/util/virterror.c        |    6 ++++++
  3 files changed, 9 insertions(+), 1 deletions(-)

ACK.

Thanks. I fixed the typo and wording of the sentence (It really didn't make much sense :( ) and pushed.

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]