[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3 5/8] Add virDomain{G, S}etNumaParameters support to the remote driver



On Fri, Dec 16, 2011 at 09:32:19AM -0700, Eric Blake wrote:
> On 12/15/2011 03:50 AM, Hu Tao wrote:
> > ---
> >  daemon/remote.c              |   64 ++++++++++++++++++++++++++++++++++++++++++
> >  src/remote/remote_driver.c   |   50 ++++++++++++++++++++++++++++++++
> >  src/remote/remote_protocol.x |   24 +++++++++++++++-
> >  src/remote_protocol-structs  |   16 ++++++++++
> >  4 files changed, 153 insertions(+), 1 deletions(-)
> 
> Your changes to remote_protocol-structs were incomplete (on Fedora
> systems, 'yum install dwarves' to get it right).  ACK with this squashed in:

Thanks.

I have dwarves installed but no effect(in a Fedora 14 system). Do I have
to run any commands included in dwarves, or make will call them automatically?

> 
> diff --git i/src/remote_protocol-structs w/src/remote_protocol-structs
> index ce01b5a..30e9244 100644
> --- i/src/remote_protocol-structs
> +++ w/src/remote_protocol-structs
> @@ -168,22 +168,6 @@ struct remote_node_get_memory_stats_ret {
>          } params;
>          int                        nparams;
>  };
> -struct remote_domain_set_numa_parameters_args {
> -    remote_nonnull_domain dom;
> -    remote_typed_param params<REMOTE_DOMAIN_MEMORY_PARAMETERS_MAX>;
> -    unsigned int flags;
> -};
> -
> -struct remote_domain_get_numa_parameters_args {
> -    remote_nonnull_domain dom;
> -    int nparams;
> -    unsigned int flags;
> -};
> -
> -struct remote_domain_get_numa_parameters_ret {
> -    remote_typed_param params<REMOTE_DOMAIN_MEMORY_PARAMETERS_MAX>;
> -    int nparams;
> -};
>  struct remote_node_get_cells_free_memory_args {
>          int                        startCell;
>          int                        maxcells;
> @@ -286,6 +270,22 @@ struct remote_domain_block_resize_args {
>          uint64_t                   size;
>          u_int                      flags;
>  };
> +struct remote_domain_set_numa_parameters_args {
> +    remote_nonnull_domain dom;
> +    remote_typed_param params<REMOTE_DOMAIN_MEMORY_PARAMETERS_MAX>;
> +    unsigned int flags;
> +};
> +
> +struct remote_domain_get_numa_parameters_args {
> +    remote_nonnull_domain dom;
> +    int nparams;
> +    unsigned int flags;
> +};
> +
> +struct remote_domain_get_numa_parameters_ret {
> +    remote_typed_param params<REMOTE_DOMAIN_MEMORY_PARAMETERS_MAX>;
> +    int nparams;
> +};
>  struct remote_domain_block_stats_args {
>          remote_nonnull_domain      dom;
>          remote_nonnull_string      path;
> @@ -2060,4 +2060,6 @@ enum remote_procedure {
>          REMOTE_PROC_DOMAIN_BLOCK_RESIZE = 251,
>          REMOTE_PROC_DOMAIN_SET_BLOCK_IO_TUNE = 252,
>          REMOTE_PROC_DOMAIN_GET_BLOCK_IO_TUNE = 253,
> +        REMOTE_PROC_DOMAIN_SET_NUMA_PARAMETERS = 254,
> +        REMOTE_PROC_DOMAIN_GET_NUMA_PARAMETERS = 255,
>  };
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 



-- 
Thanks,
Hu Tao


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]