[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3 8/8] Add document for new command numatune.



On 12/15/2011 03:50 AM, Hu Tao wrote:
> ---
>  tools/virsh.pod |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)

This should be squashed in with 7/8.

> 
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index c468f13..91baf4d 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -832,6 +832,19 @@ migrated to another host.
>  
>  Get the maximum migration bandwidth (in Mbps) for a domain.
>  
> +=item B<numatune> I<domain>
> +[I<--nodeset nodeset>] [I<--mode mode>]

I would swap these two.

> +[[I<--config>] [I<--live>] | [I<--current>]]
> +
> +Set or get domain's numa parameters.
> +
> +I<nodeset> is a list of numa node.Its syntax is a comma separated list

Spacing.

> +and a special markup using '-' and '^' (ex. '0-4', '0-3,^2') can also
> +be allowed. The '-' denotes the range and the '^' denotes exclusive.
> +I<mode> can be one of `strict', `interleave' and `preferred'.
> +For running domains(aka with I<--live>), the mode can't be changed,
> +and the nodeset can be changed only when the mode is `strict'.

Document --live and friends.

> +
>  =item B<reboot> I<domain-id>
>  
>  Reboot a domain.  This acts just as if the domain had the B<reboot>

I'm using this instead:

diff --git i/tools/virsh.pod w/tools/virsh.pod
index 05c7f99..085f3aa 100644
--- i/tools/virsh.pod
+++ w/tools/virsh.pod
@@ -832,18 +832,23 @@ migrated to another host.

 Get the maximum migration bandwidth (in Mbps) for a domain.

-=item B<numatune> I<domain>
-[I<--nodeset nodeset>] [I<--mode mode>]
+=item B<numatune> I<domain> [I<mode>] [I<nodeset>]
 [[I<--config>] [I<--live>] | [I<--current>]]

-Set or get domain's numa parameters.
+Set or get a domain's numa parameters, corresponding to the <numatune>
+element of domain XML.

-I<nodeset> is a list of numa node.Its syntax is a comma separated list
-and a special markup using '-' and '^' (ex. '0-4', '0-3,^2') can also
-be allowed. The '-' denotes the range and the '^' denotes exclusive.
-I<mode> can be one of `strict', `interleave' and `preferred'.
-For running domains(aka with I<--live>), the mode can't be changed,
-and the nodeset can be changed only when the mode is `strict'.
+I<mode> can be one of `strict', `interleave' and `preferred'.  For a
+running domain, the mode can't be changed, and the nodeset can be
+changed only if the domain was started with a mode of `strict'.
+
+I<nodeset> is a list of numa nodes used by the host for running the domain.
+Its syntax is a comma separated list, with '-' for ranges and '^' for
+excluding a node.
+
+If I<--live> is specified, set scheduler information of a running guest.
+If I<--config> is specified, affect the next boot of a persistent guest.
+If I<--current> is specified, affect the current guest state.

 =item B<reboot> I<domain-id>



-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]