[libvirt] [PATCHv2] console: plug memory leaks

ajia at redhat.com ajia at redhat.com
Tue Dec 20 09:40:13 UTC 2011


From: Alex Jia <ajia at redhat.com>

Using 'virReallocN' to allocate memory on virConsoleEventOnStdin,
virConsoleEventOnStdout and virConsoleEventOnStream, however, the
cleanup function virConsoleShutdown hasn't released these memory.

* tools/console.c: fix memory leaks on virConsoleShutdown.

https://bugzilla.redhat.com/show_bug.cgi?id=767488

Signed-off-by: Alex Jia <ajia at redhat.com>
---
 tools/console.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/tools/console.c b/tools/console.c
index e6118a0..63e51ce 100644
--- a/tools/console.c
+++ b/tools/console.c
@@ -101,6 +101,10 @@ virConsoleShutdown(virConsolePtr con)
         virStreamAbort(con->st);
         virStreamFree(con->st);
     }
+    if (con->streamToTerminal.data)
+        VIR_FREE(con->streamToTerminal.data);
+    if (con->terminalToStream.data)
+        VIR_FREE(con->terminalToStream.data);
     if (con->stdinWatch != -1)
         virEventRemoveHandle(con->stdinWatch);
     if (con->stdoutWatch != -1)
-- 
1.7.1




More information about the libvir-list mailing list