[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 1/6] Add API virDomain{S, G}etInterfaceParameters



On 12/29/2011 12:33 AM, Hu Tao wrote:
> The APIs are used to set/get domain's network interface's parameters.
> Currently supported parameters are bandwidth settings.
> 
> 
> * include/libvirt/libvirt.h.in: new API and parameters definition
> * python/generator.py: skip the Python API generation
> * src/driver.h: add new entry to the driver structure
> * src/libvirt_public.syms: export symbols
> ---
>  include/libvirt/libvirt.h.in |   50 ++++++++++++++++++++++++++++++++++++++++++
>  python/generator.py          |    2 +
>  src/driver.h                 |   12 ++++++++++
>  src/libvirt_public.syms      |    2 +
>  4 files changed, 66 insertions(+), 0 deletions(-)
> 
> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
> index 7f26521..f59c3b1 100644
> --- a/include/libvirt/libvirt.h.in
> +++ b/include/libvirt/libvirt.h.in
> @@ -645,6 +645,48 @@ typedef virTypedParameter *virTypedParameterPtr;
>   */
>  #define VIR_DOMAIN_SCHEDULER_SHARES "shares"
>  
> +/**
> + * VIR_DOMAIN_BANDWIDTH_IN_AVERAGE:
> + *
> + * Macro represents the inbound average of NIC bandwidth.
> + */
> +#define VIR_DOMAIN_BANDWIDTH_IN_AVERAGE "inbound.average"

We should modify these comments to state what the expected associated
type will be when using this named parameter, as well as which scheduler
it will be used with (see VIR_DOMAIN_SCHEDULER_CPU_SHARES for an example).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]