[libvirt] [PATCH] build: fix parted detection at configure time

Eric Blake eblake at redhat.com
Tue Feb 1 16:05:20 UTC 2011


On 01/31/2011 11:50 PM, Laine Stump wrote:
> On 01/31/2011 05:10 PM, Eric Blake wrote:
>> * configure.ac (PARTED_FOUND): Issue configure error if
>> --with-storage-disk=yes but no parted is found.
>>
>> -  if test "$with_storage_disk" != "no"&&  test "x$PKG_CONFIG" != "x"
>> ; then
>> -    PKG_CHECK_MODULES(LIBPARTED, libparted>= $PARTED_REQUIRED, [],
>> [PARTED_FOUND=no])
>> +  if test "$PARTED_FOUND" = yes&&  test "x$PKG_CONFIG" != "x" ; then
> 
> Just one small nit - almost everywhere else in configure.ac, the yes or
> no is quoted, but here you haven't quoted it. Operationally it makes no
> difference, it just looks "different" :-)
> 
> At any rate, ACK.

Okay, I fixed the quoting consistency, and pushed.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110201/1f843f40/attachment-0001.sig>


More information about the libvir-list mailing list