[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/4 v2] cgroup: Implement blkio.weight tuning API.



On Thu, 27 Jan 2011 13:18:44 +0800, Gui Jianfeng <guijianfeng cn fujitsu com> wrote:
> Implement blkio.weight tuning API.
> 
> Signed-off-by: Gui Jianfeng <guijianfeng cn fujitsu com>
> ---
>  src/libvirt_private.syms |    2 ++
>  src/util/cgroup.c        |   39 +++++++++++++++++++++++++++++++++++++++
>  src/util/cgroup.h        |    3 +++
>  3 files changed, 44 insertions(+), 0 deletions(-)
> 
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index 2ce4bed..97b9851 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -77,6 +77,8 @@ virCgroupMounted;
>  virCgroupRemove;
>  virCgroupSetCpuShares;
>  virCgroupSetFreezerState;
> +virCgroupSetWeight;
> +virCgroupGetWeight;

As and after thought, shouldn't we call this as

virCgroupSetBlkioWeight
virCgroupGetBlkioWeight

The current API does not indicate that it is Block IO weight.

Nikunj



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]