Re: [libvirt] [PATCH 2/3] Set QEMUD_CMD_FLAG_PCI_MULTIBUS for x86_64 and i686 architectures

["Daniel P. Berrange" <berrange redhat com>]

On Tue, Feb 01, 2011 at 04:22:02PM +0000, Niels de Vos wrote:
> Only x86_64 and i686 seem to have support for multiple PCI-busses. When
> a guest of these architectures is started, set the
> QEMUD_CMD_FLAG_PCI_MULTIBUS flag.
> 
> Signed-off-by: Niels de Vos <devos fedoraproject org>
> ---
>  src/qemu/qemu_command.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index 457c8b0..0899710 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -2640,6 +2640,12 @@ qemuBuildCommandLine(virConnectPtr conn,
>          break;
>      }
>  
> +    /* Currently only x86_64 and i686 support PCI-multibus. */
> +    if (STREQLEN(def->os.arch, "x86_64", 6) ||
> +        STREQLEN(def->os.arch, "i686", 4)) {
> +        qemuCmdFlags |= QEMUD_CMD_FLAG_PCI_MULTIBUS;
> +    }
> +
>      cmd = virCommandNewArgList(emulator, "-S", NULL);

We can just do a straight STREQ() here, rather
than STREQLEN. Also this patch should be merged
into the previous one, otherwise there is a
temporary regression for x86 after patch 1
ACK

Daniel