[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 1/5] smartcard: add XML support for <smartcard> device



On Tue, Feb 01, 2011 at 09:48:52AM -0700, Eric Blake wrote:
> Assuming a hypervisor that supports multiple smartcard devices in the
> guest, this would be a valid XML description:
> 
> <devices>
>   <smartcard mode='host'/>
>   <smartcard mode='host-certificates'>
>     <certificate>/path/to/cert1</certificate>
>     <certificate>/path/to/cert2</certificate>
>     <certificate>/path/to/cert3</certificate>
>   </smartcard>
>   <smartcard mode='passthrough' type='tcp'>
>     <source mode='connect' host='127.0.0.1' service='2001'/>
>     <protocol type='raw'/>
>   </smartcard>
> </devices>
> 
> * docs/formatdomain.html.in (Smartcard devices): New section.
> * docs/schemas/domain.rng (smartcard): New define, used in
> devices.
> * tests/qemuxml2argvdata/qemuxml2argv-smartcard-host.xml: New file
> to test schema.
> * tests/qemuxml2argvdata/qemuxml2argv-smartcard-host-certificates.xml:
> Likewise.
> * tests/qemuxml2argvdata/qemuxml2argv-smartcard-passthrough-tcp.xml:
> Likewise.
> * tests/qemuxml2argvdata/qemuxml2argv-smartcard-controller.xml:
> Likewise.
> 
> ---
> Notes:
>     v2: incoporate feedback from RFC, make passthrough type default to tcp
>     v3: add optional <address> per <smartcard>, enhance <controller>
>       to understand ccid, add optional <database> in mode hosts-certificates,
>       optional <source> in mode hosts, add another test file, revert v2
>       passthrough mode back to requiring explicit type
>     v4: drop <source> in host mode, relax <certificate> in host-certificates,
>       document default <database> directory
>  docs/formatdomain.html.in                          |   95 +++++++++++++++++++-
>  docs/schemas/domain.rng                            |   66 ++++++++++++++
>  .../qemuxml2argv-smartcard-controller.xml          |   19 ++++
>  .../qemuxml2argv-smartcard-host-certificates.xml   |   20 ++++
>  .../qemuxml2argv-smartcard-host.xml                |   16 ++++
>  .../qemuxml2argv-smartcard-passthrough-tcp.xml     |   19 ++++
>  6 files changed, 234 insertions(+), 1 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-smartcard-controller.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-smartcard-host-certificates.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-smartcard-host.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-smartcard-passthrough-tcp.xml

ACK

Daniel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]