[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] Support booting from hostdev devices



On 02/03/2011 07:13 AM, Jiri Denemark wrote:
> ---
>  docs/formatdomain.html.in |   14 ++++++++++++--
>  docs/schemas/domain.rng   |    3 +++
>  src/conf/domain_conf.c    |   18 +++++++++++++++---
>  src/conf/domain_conf.h    |    1 +
>  4 files changed, 31 insertions(+), 5 deletions(-)

Yeah - docs on the first submission!  We're making progress at drilling
this into everyone's heads (including mine).

>  static virDomainHostdevDefPtr
>  virDomainHostdevDefParseXML(const xmlNodePtr node,
> -                            int flags) {
> +                            virBitmapPtr bootMap,
> +                            int flags)
> +{

Don't you love sneaking in little style patches, like moving the
function open {, while touching that line for other reasons? :)

Wow, this patch was pretty easy to follow; it's a sign of good
factorization in your first patch for both disk and nic, when it was
trivial to copy those two patterns to extend it to a third client.

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]