[libvirt] [PATCH] macvtap.c: add parenthesis for similar expressions
Stefan Berger
stefanb at us.ibm.com
Thu Feb 3 19:40:04 UTC 2011
Eric Blake <eblake at redhat.com> wrote on 02/03/2011 02:31:13 PM:
>
> On 02/03/2011 11:41 AM, Stefan Berger wrote:
> >> Actually, you've uncovered a bigger bug, but didn't fix it right.
> >
> > ohoh, yes, there's a bug. This is how it should look like
> >
> > ---
> > src/util/macvtap.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Index: libvirt-acl/src/util/macvtap.c
> > ===================================================================
> > --- libvirt-acl.orig/src/util/macvtap.c
> > +++ libvirt-acl/src/util/macvtap.c
> > @@ -1048,8 +1048,8 @@ doPortProfileOpSetLink(bool nltarget_ker
> >
> > memcpy(ifla_vf_mac.mac, macaddr, 6);
> >
> > - if (!nla_put(nl_msg, IFLA_VF_MAC, sizeof(ifla_vf_mac),
> > - &ifla_vf_mac) < 0)
> > + if (nla_put(nl_msg, IFLA_VF_MAC, sizeof(ifla_vf_mac),
> > + &ifla_vf_mac) < 0)
> > goto buffer_too_small;
>
> ACK.
>
Pushed.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110203/95428df6/attachment-0001.htm>
More information about the libvir-list
mailing list