[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv5 2/9] smartcard: add domain conf support



On Thu, Feb 03, 2011 at 21:01:13 -0700, Eric Blake wrote:
> * src/conf/domain_conf.h (virDomainSmartcardType): New enum.
> (virDomainSmartcardDef, virDomainDeviceCcidAddress): New structs.
> (virDomainDef): Include smartcards.
> (virDomainSmartcardDefIterator): New typedef.
> (virDomainSmartcardDefFree, virDomainSmartcardDefForeach): New
> prototypes.
> (virDomainControllerType, virDomainDeviceAddressType): Add ccid
> enum values.
> (virDomainDeviceInfo): Add ccid address type.
> * src/conf/domain_conf.c (virDomainSmartcard): Convert between
> enum and string.
> (virDomainSmartcardDefParseXML, virDomainSmartcardDefFormat)
> (virDomainSmartcardDefFree, virDomainDeviceCcidAddressParseXML)
> (virDomainDefMaybeAddSmartcardController): New functions.
> (virDomainDefParseXML): Parse the new XML.
> (virDomainDefFormat): Convert back to XML.
> (virDomainDefFree): Clean up.
> (virDomainDeviceInfoIterate): Iterate over passthrough aliases.
> (virDomainController, virDomainDeviceAddress)
> (virDomainDeviceInfoParseXML, virDomainDeviceInfoFormat)
> (virDomainDefAddImplicitControllers): Support new values.
> * src/libvirt_private.syms (domain_conf.h): New exports.
> * cfg.mk (useless_free_options): List new function.
> 
> ---
> Notes:
>     v2: first version of patch (v1 was xml proposal only)
>     v3: add controller type='ccid' support, extra smartcard element support
>     v4: remove host/dev, relax host-certificates/cert to be any string, define
>     default host-certificates/database value
>     v5: no change

True, no change since the previous acked version.

ACK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]