[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv5 3/9] smartcard: check for qemu capability



On Thu, Feb 03, 2011 at 21:01:14 -0700, Eric Blake wrote:
> Qemu smartcard/spicevmc support exists on branches (such as
> http://cgit.freedesktop.org/~alon/qemu/commit/?h=usb_ccid.v15&id=024a37b)
> but is not yet upstream.  The added -help output matches a scratch build
> that will be close to the RHEL 6.1 qemu-kvm.
> 
> * src/qemu/qemu_capabilities.h (QEMUD_CMD_FLAG_CCID_EMULATED)
> (QEMUD_CMD_FLAG_CCID_PASSTHRU, QEMUD_CMD_FLAG_CHARDEV_SPICEVMC):
> New flags.
> * src/qemu/qemu_capabilities.c (qemuCapsComputeCmdFlags)
> (qemuCapsParseDeviceStr): Check for smartcard capabilities.
> (qemuCapsExtractVersionInfo): Tweak comment.
> * tests/qemuhelptest.c (mymain): New test.
> * tests/qemuhelpdata/qemu-kvm-0.12.1.2-rhel61: New file.
> * tests/qemuhelpdata/qemu-kvm-0.12.1.2-rhel61-device: Likewise.
> 
> ---
> Notes:
>     v2: new patch
>     v3: rebase to latest tree
>     v4: no change
>     v5: split check into two bits, to match upstream qemu configure flags;
>     also check for spicevmc support, add a test from RHEL 6.1 scratch build
>  src/qemu/qemu_capabilities.c                       |   17 +-
>  src/qemu/qemu_capabilities.h                       |    3 +
>  tests/qemuhelpdata/qemu-kvm-0.12.1.2-rhel61        |  229 ++++++++++++++++++++
>  tests/qemuhelpdata/qemu-kvm-0.12.1.2-rhel61-device |   74 +++++++
>  tests/qemuhelptest.c                               |   43 ++++
>  5 files changed, 361 insertions(+), 5 deletions(-)
>  create mode 100644 tests/qemuhelpdata/qemu-kvm-0.12.1.2-rhel61
>  create mode 100644 tests/qemuhelpdata/qemu-kvm-0.12.1.2-rhel61-device

ACK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]