[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv5 10/9] spicevmc: support older -device spicevmc of qemu 0.13.0



On Fri, Feb 04, 2011 at 09:16:25 -0700, Eric Blake wrote:
> qemu 0.13.0 (at least as built for Fedora 14, and also backported to
> RHEL 6.0 qemu) supported an older syntax for a spicevmc channel; it's
> not as flexible (it has an implicit name and hides the chardev
> aspect), but now that we support spicevmc, we might as well target
> both variants.

> --- a/src/qemu/qemu_capabilities.h
> +++ b/src/qemu/qemu_capabilities.h
> @@ -90,7 +90,8 @@ enum qemuCapsFlags {
>      QEMUD_CMD_FLAG_PCI_BOOTINDEX = (1LL << 53), /* pci-assign.bootindex */
>      QEMUD_CMD_FLAG_CCID_EMULATED = (1LL << 54), /* -device ccid-card-emulated */
>      QEMUD_CMD_FLAG_CCID_PASSTHRU = (1LL << 55), /* -device ccid-card-passthru */
> -    QEMUD_CMD_FLAG_CHARDEV_SPICEVMC = (1LL << 56), /* -chardev spicevmc */
> +    QEMUD_CMD_FLAG_CHARDEV_SPICEVMC = (1LL << 56), /* newer -chardev spicevmc */
> +    QEMUD_CMD_FLAG_DEVICE_SPICEVMC = (1LL << 57), /* older -device spicevmc*/
>  };

Oh, we are getting very close to 64. I'd better start working on the virBitmap
rewrite.

> diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h
> index 6d57007..8135046 100644
> --- a/src/qemu/qemu_command.h
> +++ b/src/qemu/qemu_command.h
> @@ -105,8 +105,6 @@ char * qemuBuildPCIHostdevDevStr(virDomainHostdevDefPtr dev,
> 
>  int qemuOpenPCIConfig(virDomainHostdevDefPtr dev);
> 
> -char * qemuBuildVirtioSerialPortDevStr(virDomainChrDefPtr dev);
> -
>  /* Legacy, pre device support */
>  char * qemuBuildUSBHostdevUsbDevStr(virDomainHostdevDefPtr dev);
>  /* Current, best practice */

OK, apparently not used outside of qemu_command.c

ACK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]