[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv5 9/9] smartcard: add spicevmc support



On 02/04/2011 09:25 AM, Jiri Denemark wrote:
> On Thu, Feb 03, 2011 at 21:16:11 -0700, Eric Blake wrote:
>> Adds <smartcard mode='passthrough' type='spicevmc'/>, which uses the
>> new <channel name='smartcard'/> of <graphics type='spice'>.
> ...
>> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
>> index d91fdb9..43c78fc 100644
>> --- a/docs/formatdomain.html.in
>> +++ b/docs/formatdomain.html.in
>> @@ -1505,8 +1508,9 @@ qemu-kvm -net nic,model=? /dev/null
>>    can be desirable to restrict what channels can be run on each port.
>>    This is achieved by adding one or more &lt;channel&gt; elements inside
>>    the main &lt;graphics&gt; element. Valid channel names include
>> -  <code>main</code>,<code>display</code>,<code>inputs</code>,<code>cursor</code>,
>> -  <code>playback</code>,<code>record</code>.
>> +  <code>main</code>, <code>display</code>, <code>inputs</code>,
>> +  <code>cursor</code>, <code>playback</code>, <code>record</code>;
>> +  and <span class="since">since 0.8.8</span>: <code>smartcard</code>.
>>  	    </p>
>>  	    <pre>
>     ^^ tabs before spaces, but that's in a context, not your fault. It could be
>     worth fixing while touching the lines above. But it's not a big deal.
>>    &lt;graphics type='spice' port='-1' tlsPort='-1' autoport='yes'&gt;
> 
> ACK

Thanks for the series review.  I've nuked the bogus 7 and 8 (the
experiment and its reversion), and pushed the remaining 8 patches.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]