[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Support SCSI RAID type & lower log level for unknown types



On 02/07/2011 10:41 AM, Daniel P. Berrange wrote:
> The Linux kernel headers don't have a value for SCSI type 12,
> but HAL source code shows this to be a 'raid'. Add workaround
> for this type. Lower log level for unknown types since
> this is not a fatal error condition. Include the device sysfs
> path in the log output to allow identification of which device
> has problems.
> 
> * src/node_device/node_device_udev.c: Add SCSI RAID type
> ---
>  src/node_device/node_device_udev.c |   15 ++++++++++++---
>  1 files changed, 12 insertions(+), 3 deletions(-)

ACK.

> 
> diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
> index 2da5529..93390af 100644
> --- a/src/node_device/node_device_udev.c
> +++ b/src/node_device/node_device_udev.c
> @@ -41,6 +41,10 @@
>  
>  #define VIR_FROM_THIS VIR_FROM_NODEDEV
>  
> +#ifndef TYPE_RAID
> +# define TYPE_RAID 12
> +#endif

Is there a bug open against the kernel-headers to eventually get this
into the correct place for everyone else to use?

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]