[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/6] sysinfo: expose new API



On Mon, Feb 07, 2011 at 05:08:45PM -0700, Eric Blake wrote:
> * include/libvirt/libvirt.h.in (virConnectGetSysinfo): Declare.
> * src/libvirt_public.syms: Export new symbol.
> ---
> 
> I don't know how the flags argument might be used, if ever, but
> better safe than sorry :)
> 
>  include/libvirt/libvirt.h.in |    4 +++-
>  src/libvirt_public.syms      |    5 +++++
>  2 files changed, 8 insertions(+), 1 deletions(-)
> 
> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
> index 7ecbeb6..3913a28 100644
> --- a/include/libvirt/libvirt.h.in
> +++ b/include/libvirt/libvirt.h.in
> @@ -4,7 +4,7 @@
>   * Description: Provides the interfaces of the libvirt library to handle
>   *              virtualized domains
>   *
> - * Copy:  Copyright (C) 2005,2006,2010 Red Hat, Inc.
> + * Copy:  Copyright (C) 2005-2006 2010-2011 Red Hat, Inc.
>   *
>   * See COPYING.LIB for the License of this software
>   *
> @@ -575,6 +575,8 @@ int                     virConnectGetLibVersion (virConnectPtr conn,
>                                                   unsigned long *libVer);
>  char *                  virConnectGetHostname   (virConnectPtr conn);
>  char *                  virConnectGetURI        (virConnectPtr conn);
> +char *                  virConnectGetSysinfo    (virConnectPtr conn,
> +                                                 unsigned int flags);

  Agreed looks fine to me, it's a generally useful API, people don't
like (rightfully) to write XML and we need a convenient way to extract
this. The flags may be useful in the future to limit the amount of
informations extracted, for example if we don't want the UUID exported
or something similar,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]