[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 6/6] sysinfo: implement qemu support



On Mon, Feb 07, 2011 at 05:08:50PM -0700, Eric Blake wrote:
> * src/util/sysinfo.h (virSysinfoFormat): New prototype.
> * src/conf/domain_conf.c (virDomainSysinfoDefFormat): Move guts...
> * src/util/sysinfo.c (virSysinfoFormat): ...into new function.
> * src/libvirt_private.syms: Export it.
> * src/qemu/qemu_driver.c (qemuGetSysinfo): New function.
> (qemuDriver): Install it.
> ---
> 
> Tested both with qemu:///system (works!) and qemu:///session
> (error: unsupported configuration: Host SMBIOS information is not available)
> 
> The prefix hack is necessary so that I can use "" or "  " as
> the leading indentation, depending on host sysinfo vs. domain,
> so it's not quite straight code motion.

  Yeah, the only unfortunate thing is that if people want to reuse
the output they will have to reindent (well not strictly needed, just
nicer). but it's better to generate a nice output. on input formatting
is ignored anyway !

ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]