[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/6] sysinfo: expose host <sysinfo> data from virsh

On 02/08/2011 07:36 PM, Daniel Veillard wrote:
> On Mon, Feb 07, 2011 at 05:08:44PM -0700, Eric Blake wrote:
>> First requested here:
>> https://www.redhat.com/archives/libvir-list/2011-January/msg00889.html
>> and useful enough that I coded it in one day, hopefully to be in
>> time for the 0.8.8 feature freeze :)
>> Food for thought - right now, only qemu supports this.  Should I do a
>> followup patch that moves hostsysinfo out of qemu_conf.h and into
>> src/datatypes.h virConnect instead, as well as some utility routines
>> that make it easier for all hypervisors to choose to cache sysinfo
>> data (if privileged)?  Compare to how many (but not all) hypervisors
>> share util.c virGetHostname rather than duplicating the work.
>   Yes I think we can do that small reorg, but as a separate step after 0.8.8
> is out.
>   ACK for me with the few small nits changed 

Thanks; series pushed.  (Actually, I also split patch 6 into two - the
domain_conf formatting change, vs. qemu using that change; that way, if
we ever add future smbios entries, backporting just the formatting of
those new entries will not drag in API changes; on my radar is adding
support for the block 3 Asset Tag entry.)

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]