[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: distribute 'make syntax-check' tweaks



On 02/01/2011 03:36 PM, Eric Blake wrote:
> * Makefile.am (EXTRA_DIST): Distribute cfg.mk.
> ---
> 
> I noticed that the 0.8.7 tarball lacks cfg.mk, so running 'make
> syntax-check' on that tarball is bound to have problems (without that
> file, you don't exempt tests in gnulib's maint.mk that libvirt is not
> interested in, and you miss out on lots of other tests that are
> libvirt-specific).
> 
> Tested with 'make distcheck', then inspecting the resulting tarball.
> I almost pushed this under a trivial rule, but restrained myself to
> wait for a proper review. :)
> 
>  Makefile.am |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 597ec61..882e676 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -51,6 +51,7 @@ EXTRA_DIST = \
>    autobuild.sh \
>    Makefile.nonreentrant \
>    autogen.sh \
> +  cfg.mk \
>    examples/domain-events/events-python \
>    $(syntax_check_exceptions) \
>    $(XML_EXAMPLES)

PING - this one's definitely worth including in 0.8.8.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]