[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3 2/2] Add txmode attribute to interface XML for virtio backend

On 02/10/2011 02:53 AM, Laine Stump wrote:
> ==============================
> V3 changes:
> 0) The actual code remains untouched from V2.
> 1) Add txmode attribute to the domain schema, and to an xml2xml and
>    xml2argv test (note that the particular file used for the xml2xml
>    test was previously only being used for xml2argv, and it needed
>    some cleaning up before it would work properly.
> 2) Document the attribute on the website, along with a bold warning to
>    leave it alone!

Looks good.

> +++ b/tests/qemuhelpdata/qemu-kvm-
> @@ -72,3 +72,28 @@ virtio-blk-pci.ioeventfd=on/off
>  virtio-blk-pci.vectors=uint32
>  virtio-blk-pci.indirect_desc=on/off
>  virtio-blk-pci.scsi=on/off
> +virtio-net-pci.vectors=uint32
> +virtio-net-pci.indirect_desc=on/off
> +virtio-net-pci.csum=on/off

Nice.  Should we also be updating qemu-kvm-0.13.0-device with similar
content (using the Fedora 14 qemu-kvm, for example), which has
virtio-net-pci but lacks the tx parameter, to prove that the flag does
not get set in that test case?

ACK with that nit addressed (I trust you can amend that file without
having to see a v4).  However, I'm not sure if this is okay to push now
(since you proposed the series before feature freeze) or not (since it
missed the freeze announcement and therefore is missing out on release
candidate testing); DV, can you give an answer?

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]