[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: avoid mingw printf problems

On 02/12/2011 04:54 AM, Matthias Bolte wrote:
> 2011/2/12 Eric Blake <eblake redhat com>:
>> * tools/virsh.c (vshPrint): Change redirect.
>> (vshPrintExtra): Allow use within vshPrint.  Avoid fprintf on
>> arbitrary formats, since we aren't using gnulib module; instead,
>> use virVasprintf to pre-format.
>> (vshError): Likewise.
>> Reported by Matthias Bolte.
>> ---
>> This passed for my fedora->mingw cross compile, but I'd like to
>> make sure it worked for your native mingw build setup.
> It does, ACK.

Thanks.  Since this commit was about mingw compiler warnings, I amended
it to also include a gnulib update - there was a single gnulib commit
since last update, which solves a compiler warning present on mingw when
compiling gnulib's strptime.  Then I pushed it.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]