[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Currently in freeze for 0.8.8, rc2 available



On Mon, Feb 14, 2011 at 10:30:13PM +1100, Justin Clift wrote:
> On 14/02/2011, at 9:58 PM, Daniel P. Berrange wrote:
> > It is a broken enum declaration in the header libvirt-qemu.h:

never underestimate the power of being multi platform in chasing weird bugs !

> > enum {
> >    VIR_DOMAIN_QEMU_MONITOR_COMMAND_DEFAULT = 0,
> >    VIR_DOMAIN_QEMU_MONITOR_COMMAND_HMP     = (1 << 0), /* cmd is in HMP */
> > } virDomainQemuMonitorCommandFlags;
> > 
> > 
> > There is a missing 'typedef' keyword there before 'enum', so instead of
> > defining a type, it is defining a variable :-(
> 
> Thanks Daniel (Berrange), that's perfect, it really was that simple. :)  (whew!)
> 
> Just submitted the simple 1 line fix adding "typedef" before the enum,
> and it works on OSX now.  (still working on F13 too, no breakage caused)
> 
> Daniel (Veillard) do you reckon it's worth knocking out a 0.8.8rc3 quickly
> or something?

  okay, I will make another one tomorrow morning to accumulate a bit more
patches :-)

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]