[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: avoid NULL derefs



On 02/14/2011 08:26 PM, Daniel Veillard wrote:
> On Mon, Feb 14, 2011 at 04:59:39PM -0700, Eric Blake wrote:
>> The processWatchdogEvent fix is real, although it can only trigger on
>> OOM, since bad things happen if doCoreDump is called with a NULL
>> pathname argument.  The other fixes silence clang, but aren't a real
>> bug because virReportErrorHelper tolerates a NULL format string even
>> though *printf does not.
>>
>> * src/qemu/qemu_driver.c (processWatchdogEvent): Exit on OOM.
>> (qemuDomainIsActive, qemuDomainIsPersistent, qemuDomainIsUpdated):
>> Provide valid message.
> 
>   ACK, fine pushing now,

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]