[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] Avoid empty strings when --with-packager(-version) is not specified



I pushed this patch already ACKed by Eric:

https://www.redhat.com/archives/libvir-list/2011-February/msg00550.html

Matthias
From 251ad3b28b2534f840549fc5837ca5f3c5993e30 Mon Sep 17 00:00:00 2001
From: Matthias Bolte <matthias bolte googlemail com>
Date: Tue, 15 Feb 2011 19:48:44 +0100
Subject: [PATCH] Avoid empty strings when --with-packager(-version) is not specified

Make with_packager and with_packager_version default to "no". This way
--without-packager-version (as shorthand for --with-packager(-version)=no)
works correctly too.

Prior to this patch libvirt outputs a line like this when
--with-packager(-version) was not specified

# ./daemon/libvirtd
14:11:15.018: 31796: info : libvirt version: 0.8.8, package:  ()

Now the unspecified parts are correctly omitted.

Reported by Osier Yang.
---
 configure.ac |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 3cd824a..9caa902 100644
--- a/configure.ac
+++ b/configure.ac
@@ -32,11 +32,11 @@ AC_SUBST([LIBVIRT_VERSION_NUMBER])
 AC_ARG_WITH([packager],
             [AS_HELP_STRING([--with-packager],
                             [Extra packager name])],
-            [],[])
+            [],[with_packager=no])
 AC_ARG_WITH([packager-version],
             [AS_HELP_STRING([--with-packager-version],
                             [Extra packager version])],
-            [],[])
+            [],[with_packager_version=no])
 if test "x$with_packager" != "xno"
 then
   AC_DEFINE_UNQUOTED([PACKAGER], ["$with_packager"],
-- 
1.7.0.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]