[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-php 2/2] Added checkings for tools and libraries



On Fri, Feb 18, 2011 at 03:51:32PM +0800, Lyre wrote:
> * configure.ac: Added checkings for compiler, sed, install, and so on;
>   Added AM_PATH_XML2 to check libxml2.
> * src/Makefile.am: dropped needless macros since it is done by autoconf;
>   Use $INSTALL to install files rather than cp.
> ---
>  aclocal.m4      |  189 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  configure.ac    |   12 ++++
>  src/Makefile.am |   30 +++------
>  3 files changed, 212 insertions(+), 19 deletions(-)
> 
> diff --git a/aclocal.m4 b/aclocal.m4
> index a1fa316..982143e 100644
> --- a/aclocal.m4
> +++ b/aclocal.m4
> @@ -19,6 +19,195 @@ You have another version of autoconf.  It may work, but is not guaranteed to.
>  If you have problems, you may need to regenerate the build system entirely.
>  To do so, use the procedure documented by the package, typically `autoreconf'.])])
>  
> +# Configure paths for LIBXML2
> +# Mike Hommey 2004-06-19
> +# use CPPFLAGS instead of CFLAGS
> +# Toshio Kuratomi 2001-04-21
> +# Adapted from:
> +# Configure paths for GLIB
> +# Owen Taylor     97-11-3
> +
> +dnl AM_PATH_XML2([MINIMUM-VERSION, [ACTION-IF-FOUND [, ACTION-IF-NOT-FOUND]]])
> +dnl Test for XML, and define XML_CPPFLAGS and XML_LIBS
> +dnl

[snip]

This code looks rather overly long & complex. I'd suggest taking the
libxml2 check from libvirt's  configure.ac file & using that instead.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]