[libvirt] [PATCH] check device-mapper when building without storage mpath

Osier Yang jyang at redhat.com
Fri Feb 18 12:12:08 UTC 2011


于 2011年02月18日 17:00, Justin Clift 写道:
> On 18/02/2011, at 7:46 PM, Jiri Denemark wrote:
> <snip>
>>
>>> Thanks for the fix, actually It can be reproduced simply by:
>>> % ./autogen.sh --with-storage-mpath=no
>>> % make
>>>
>>> As src/util/util.c invokes "dm_is_dm_major".
>>
>> Yes it does, but I'm not convinced this is the right approach to fix it. Why
>> should libvirt always require device-mapper libraries?
>
> As a data point, device-mapper isn't available on non-Linux platforms.  If
> Osier was meaning to make it "required", I can see a problem about there. ;)

That's a problem indeed, but we already required it to use "parted" to
create storage volume. Perhaps we need a better solution, but currently
I have no better idea. :-)

Regards
Osier




More information about the libvir-list mailing list