[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] maint: avoid 'make syntax-check' from tarball



On 02/17/2011 01:51 PM, Eric Blake wrote:
> On 02/16/2011 08:14 PM, Daniel Veillard wrote:
>> On Wed, Feb 16, 2011 at 02:39:30PM -0700, Eric Blake wrote:
>>> * .gnulib: update to latest gnulib for maint.mk fixes
>>> ---
>>>
>>> In testing the latest release candidate, I ran 'make syntax-check'
>>> out of habit, and it died miserably (even hanging waiting for
>>> input on stdin).  So I fixed maint.mk upstream:
>>> http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/25340
>>>
>>> However, we're so close to the release that I don't know if we want
>>> this now, or if we just document that 0.8.8 is the last release where
>>> 'make syntax-check' on the tarball is expected to fail.
>>
>> Let's keep as is for 0.8.8 considering the existing amount of testing of rc3
> 
> Assuming this was an ACK for post-release, I've now pushed the patch.

And now I'm glad I waited until post-release; it appears that this
gnulib update dragged in some code which broke cross-compilation
detection of long long support, so I'm trying to get that resolved
upstream in gnulib.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]