[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] check device-mapper when building without storage mpath



On 02/18/2011 01:21 AM, Osier Yang wrote:
> 于 2011年02月18日 11:00, Wen Congyang 写道:
>> When I build libvirt without libvirtd, I receive the following errors:
>>    GEN    virsh.1
>>    CCLD   virsh
>> ../src/.libs/libvirt.so: undefined reference to `dm_is_dm_major'
>> collect2: ld returned 1 exit status
>> make[3]: *** [virsh] Error 1
> Thanks for the fix, actually It can be reproduced simply by:

> % ./autogen.sh --with-storage-mpath=no
> % make
> 
> As src/util/util.c invokes "dm_is_dm_major".

It's also reproducible with a mingw build:

  CC     libvirt_util_la-util.lo
../../src/util/util.c:48:26: fatal error: libdevmapper.h: No such file
or directory
compilation terminated.

I agree with danpb's approach that virIsDevMapperDevice should be a
no-op for other platforms, so I'll be coming up with something along
those lines soon.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]