[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] RFC: make <mac> element required?



On Fri, Feb 18, 2011 at 06:51:36PM +0100, Michal Prívozník wrote:
> Hi,
> 
> I am about to fix https://bugzilla.redhat.com/show_bug.cgi?id=616721
> It seems to me that problem is libvirt inserts a new element <mac
> address='...'> during parsing interface XML with random mac address
> which result in error described in BZ.
> 
> I am not sure wheter to fix it just in virsh or in
> virDomainDetachDevice() as well. If in virsh, then other application
> may fail without knowing why. But isn't the second option too
> aggressive?

We can't change the parser, since apps expect libvirt to auto-fill the
MAC address.  The virsh detach-interface command should be mandating
the MAC parameter though. There is no other meaningful unique key for
interfaces in general.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]