[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] protect the scsi controller to be deleted when it is in use



On Mon, Feb 21, 2011 at 03:35:52PM +0800, Wen Congyang wrote:
> Steps to reproduce this bug:
> 1. virsh attach-disk domain --source imagefile --target sdb --sourcetype file --driver qemu --subdriver raw
> 2. virsh detach-device controller.xml # remove scsi controller 0
> 3. virsh detach-disk domain sdb
>    error: Failed to detach disk
>    error: operation failed: detaching scsi0-0-1 device failed: Device 'scsi0-0-1' not found
> 
> I think we should not detach a controller when it is used by some other device.
> 
> Signed-off-by: Wen Congyang <wency cn fujitsu com>

ACK, this looks like a good idea.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]