[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] virt-pki-validate: behave when CERTTOOL is missing



On Sun, Feb 20, 2011 at 10:29:25PM +0200, Dan Kenigsberg wrote:
> ---
>  tools/virt-pki-validate.in |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/virt-pki-validate.in b/tools/virt-pki-validate.in
> index 207fa76..96659cf 100755
> --- a/tools/virt-pki-validate.in
> +++ b/tools/virt-pki-validate.in
> @@ -14,7 +14,7 @@ PORT=16514
>  # First get certtool
>  #
>  CERTOOL=`which certtool 2>/dev/null`
> -if [ ! -x $CERTOOL ]
> +if [ ! -x "$CERTOOL" ]
>  then
>      echo "Could not locate the certtool program"
>      echo "make sure the gnutls-utils (or gnutls-bin) package is installed"

ACK, though we should have an RPM dep on gnutls-utils to make sure
this is always present !

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]