[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] virt-*-validate.in: quote all variable references



On Sun, Feb 20, 2011 at 10:29:26PM +0200, Dan Kenigsberg wrote:
> Alas, the shell is not a real programming language.
> 
> Patch generated by manual confirmation of vim's
> s/[^"]\@<=\$\S\+\s\ =/"&"/gc
> and
> s/\(echo \)\@<=[^"].*\$.*$/"&"/c matches.
> 
> This patch generate a lot of noise and carries little benefits, as
> I do not really expect $PKI to contain spaces or backticks. I'm just
> fuming, and would not really mind if this patch is ignored
> ---
>  tools/virt-pki-validate.in |   64 ++++++++++++++++++++++----------------------
>  tools/virt-xml-validate.in |   10 +++---
>  2 files changed, 37 insertions(+), 37 deletions(-)


ACK,  shell found to be evil :-(

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]