[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/8] Moved SEXPR parsing functions to xenxs



On 02/21/2011 10:19 AM, Daniel P. Berrange wrote:
> On Mon, Feb 21, 2011 at 02:40:08PM +0100, Markus Groß wrote:
>> +XENXS_SOURCES =							\
>> +		xenxs/xenxs_private.h				\
>> +		xenxs/xen_sxpr.c xenxs/xen_sxpr.h
>> +
>>  pkgdata_DATA =	cpu/cpu_map.xml
> 
> 
> You also need to add $(XENXS_SOURCES) to the huge
> EXTRA_DIST  entry later, so that the files get
> included in the tar.gz even if 'make dist' is run
> on a system without xen.
> 
> ACK to the rest of the patch if that bit is fixed

I'm pushing, after squashing this in:

diff --git i/src/Makefile.am w/src/Makefile.am
index 1e670e5..4a64eb1 100644
--- i/src/Makefile.am
+++ w/src/Makefile.am
@@ -1008,7 +1008,8 @@ EXTRA_DIST +=							\
 		$(SECURITY_DRIVER_APPARMOR_SOURCES)		\
 		$(SECRET_DRIVER_SOURCES)			\
 		$(VBOX_DRIVER_EXTRA_DIST)			\
-		$(VMWARE_DRIVER_SOURCES)
+		$(VMWARE_DRIVER_SOURCES)			\
+		$(XENXS_SOURCES)

 check-local: augeas-check

diff --git i/src/xenxs/xenxs_private.h w/src/xenxs/xenxs_private.h
index 02fd1a3..1acabfb 100644
--- i/src/xenxs/xenxs_private.h
+++ w/src/xenxs/xenxs_private.h
@@ -28,9 +28,9 @@
 # include "internal.h"


-#define VIR_FROM_THIS VIR_FROM_NONE
+# define VIR_FROM_THIS VIR_FROM_NONE

-#define XENXS_ERROR(code, ...)
       \
+# define XENXS_ERROR(code, ...)
       \
     virReportErrorHelper(NULL, VIR_FROM_NONE, code, __FILE__,
__FUNCTION__,   \
                          __LINE__, __VA_ARGS__)



-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]