[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/6] libvirt: Implements virDomainSetBlkioParameters and virDomainGetBlkioParameters and initialization



On 02/21/2011 02:47 AM, Gui Jianfeng wrote:
> Implements virDomainSetBlkioParameters and virDomainGetBlkioParameters and initialization
> 
> Signed-off-by: Gui Jianfeng <guijianfeng cn fujitsu com>
> ---
>  src/driver.h               |   14 ++++++
>  src/esx/esx_driver.c       |    2 +
>  src/libvirt.c              |  108 ++++++++++++++++++++++++++++++++++++++++++++
>  src/libvirt_public.syms    |    6 +++
>  src/lxc/lxc_driver.c       |    2 +
>  src/openvz/openvz_driver.c |    2 +
>  src/phyp/phyp_driver.c     |    2 +
>  src/qemu/qemu_driver.c     |    2 +
>  src/remote/remote_driver.c |    2 +
>  src/test/test_driver.c     |    2 +
>  src/uml/uml_driver.c       |    2 +
>  src/vmware/vmware_driver.c |    2 +
>  src/xen/xen_driver.c       |    2 +
>  13 files changed, 148 insertions(+), 0 deletions(-)
> 
> @@ -615,6 +627,8 @@ struct _virDriver {
>      virDrvDomainSetMemoryParameters domainSetMemoryParameters;
>      virDrvDomainGetMemoryParameters domainGetMemoryParameters;
>      virDrvDomainOpenConsole domainOpenConsole;
> +    virDrvDomainSetBlkioParameters domainSetBlkioParameters;
> +    virDrvDomainGetBlkioParameters domainGetBlkioParameters;
>  };

This is an internal struct; I think it makes more sense to group related
callbacks than to place new callbacks at the end.  That is, I would have
inserted these two new callbacks between domainGetMemoryParameters and
domainOpenConsole, rather than after domainOpenConsole.  However, that
has knock-on effects to the rest of this patch and to a lesser extent
the rest of the series, so I'll leave it up to you whether to adjust the
positioning in a respin.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]