[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add APIs for killing off processes inside a cgroup



On Wed, Feb 23, 2011 at 07:58:36AM -0700, Eric Blake wrote:
> On 02/23/2011 04:23 AM, Daniel P. Berrange wrote:
> > On Tue, Feb 22, 2011 at 11:17:05AM -0700, Eric Blake wrote:
> >> On 02/22/2011 10:55 AM, Daniel P. Berrange wrote:
> >>> The virCgroupKill method kills all PIDs found in a cgroup
> >>>
> >>> The virCgroupKillRecursively method does this recursively
> >>> for child cgroups.
> >>>
> >>> The virCgroupKillPainfully method does a recursive kill
> >>> several times in a row until everything has really died
> >>
> >> Do we really need three APIs, or can we just have:
> >>
> >> virCgroupKill(..., VIR_CGROUP_KILL_RECURSIVE | VIR_CGROUP_KILL_PAINFUL)
> > 
> > The last method loops, calling into the 2nd method, and the
> > 2nd method loops, calling into the 1st, so architecturally
> > it doesn't work to have only one method with flags.
> 
> So under the hood it's easier to implement with three functions.  But
> still, from the user's point of view (including remote rpcs), why not
> have just one function with flags?

This isn't a public API. Its just an internal thing, so there's
no reason not to restrict visibility of them.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]