[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Put <stdbool.h> into internal.h so it is available everywhere



On 02/23/2011 05:14 AM, Daniel P. Berrange wrote:
> Remove the <stdbool.h> header from all source files / headers
> and just put it into internal.h
> 
> * src/internal.h: Add <stdbool.h>

I was about to ACK this, but then I did a spot check:

> 
> diff --git a/daemon/dispatch.c b/daemon/dispatch.c
> index 3397a00..dc3b48a 100644
> --- a/daemon/dispatch.c
> +++ b/daemon/dispatch.c
> @@ -26,7 +26,6 @@
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <stdarg.h>
> -#include <stdbool.h>
>  
>  #include "dispatch.h"
>  #include "remote.h"

Huh, dispatch.c doesn't include "internal.h".  Nor does dispatch.h or
remote.h.  This only compiled because you included "memory.h", which
eventually included "internal.h".

If we go with this approach, shouldn't we also ensure that all .c files
include "internal.h"?

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]