[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 6/7] qemu: Switch over command line capabilities to virBitmap



On Tue, Feb 22, 2011 at 10:40:12 -0700, Eric Blake wrote:
> On 02/22/2011 09:48 AM, Jiri Denemark wrote:
> > This is done for two reasons:
> > - we are getting very close to 64 flags which is the maximum we can use
> >   with unsigned long long
> > - by using LL constants in enum we already violates C99 constraint that
> >   enum values have to fit into int
> 
> > +++ b/cfg.mk
> > @@ -135,7 +135,8 @@ useless_free_options =				\
> >    --name=virThreadPoolFree			\
> >    --name=xmlFree				\
> >    --name=xmlXPathFreeContext			\
> > -  --name=xmlXPathFreeObject
> > +  --name=xmlXPathFreeObject			\
> > +  --name=qemuCapsFree
> 
> This list is sorted; can you reshuffle the lines to stick it in just
> before sexpr_free instead?

Oh, how come I didn't notice the list was actually sorted...

> ACK with the cfg.mk nit fixed.

Thanks, pushed.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]